-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxHighlighter: Safely access clipboard on global.navigator #14035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use optional chaining to safely access `clipboard` on `global.navigator`
shilman
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
shilman
added
bug
ui
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Feb 24, 2021
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Feb 24, 2021
shilman
added a commit
that referenced
this pull request
Feb 24, 2021
SyntaxHighlighter: Safely access clipboard on global.navigator
This was referenced Mar 7, 2021
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: None; discussed in Discord first
In my admittedly convoluted project (details: #12959 (comment)), I get an error about not being able to access
clipboard
onundefined
, becausenavigator
(expectedly) is not available in the environment in which it is executed.What I did
Use optional chaining to safely access
clipboard
onglobal.navigator
How to test
If your answer is yes to any of these, please make sure to include it in your PR.
Questions
A quick search shows that there may be other instances of unsafe global access. Let me know if this PR should attempt to address these, too.